[webkit-reviews] review granted: [Bug 172494] [css-grid] Update CSS Grid Layout test suite : [Attachment 310991] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 172494: [css-grid] Update CSS Grid Layout test suite
https://bugs.webkit.org/show_bug.cgi?id=172494

Attachment 310991: Patch

https://bugs.webkit.org/attachment.cgi?id=310991&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 310991
  --> https://bugs.webkit.org/attachment.cgi?id=310991
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310991&action=review

> LayoutTests/imported/w3c/ChangeLog:11
> +	   to reference files there and the importer wasn't able to get them.

It is not clear from the title how this gets updated.
Isn't it that you are adding web-platform-tests/css/css-grid-1/alignment/ and
need to update css/reference?
Ideally, you would use the wpt revision in resources/TestRepositories, by doing
something like import-w3c-tests web-platform-tests/css/css-grid-1/alignment.

>>> LayoutTests/imported/w3c/resources/import-expectations.json:-65
>>> -	 "web-platform-tests/cssom/MediaList.xhtml": "skip", 
>> 
>> nit: Why this line change ?
> 
> That file is updated by the import script, not manually so I prefer to let it
do whatever change it wants on it. :-)

Yes, this line was added manually but the importer is reordering these.