[webkit-reviews] review denied: [Bug 172467] Web Inspector: Don't load the active recording until a Timeline view needs to be shown : [Attachment 310906] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Devin Rousso
<drousso at apple.com>'s request for review:
Bug 172467: Web Inspector: Don't load the active recording until a Timeline
view needs to be shown
https://bugs.webkit.org/show_bug.cgi?id=172467

Attachment 310906: Patch

https://bugs.webkit.org/attachment.cgi?id=310906&action=review




--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 310906
  --> https://bugs.webkit.org/attachment.cgi?id=310906
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310906&action=review

r- for question below.

> Source/WebInspectorUI/ChangeLog:12
> +	   `_displayedRecording` isn't already set.  This delays the creation
of the content view for

Style: One space after a period.

> Source/WebInspectorUI/ChangeLog:19
> +
> +

Style: Too many blank lines

> Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js:537
> +	   if (!this._displayedRecording &&
WebInspector.timelineManager.activeRecording)
> +	       this._recordingLoaded();

I think this deserves a comment, because it is really not the right place for
this.

Perhaps it should just be inside a function named `_lazyInitialization`. It is
also unclear to me why this is the correct place and not something like `shown`
or `restoreFromCookie`. Can you describe why this is the most appropriate?