[webkit-reviews] review granted: [Bug 169453] Update font-style's implementation in the font selection algorithm : [Attachment 310963] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 169453: Update font-style's implementation in the font selection algorithm
https://bugs.webkit.org/show_bug.cgi?id=169453

Attachment 310963: Patch

https://bugs.webkit.org/attachment.cgi?id=310963&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 310963
  --> https://bugs.webkit.org/attachment.cgi?id=310963
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310963&action=review

> Source/WebCore/css/FontFace.cpp:293
> +    auto minimum =
ComputedStyleExtractor::fontStyleFromStyleValue(style.minimum, true);
> +    auto maximum =
ComputedStyleExtractor::fontStyleFromStyleValue(style.maximum, true);

Would read better with an enum argument. Enum could mention italic/oblique
which would make this all easier to follow.