[webkit-reviews] review requested: [Bug 171904] Web Inspector: Web Sockets: Unable to inspect a WebSocket that receives >50 messages per second : [Attachment 310948] Patch

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <nvasilyev at apple.com> has asked  for review:
Bug 171904: Web Inspector: Web Sockets: Unable to inspect a WebSocket that
receives >50 messages per second
https://bugs.webkit.org/show_bug.cgi?id=171904

Attachment 310948: Patch

https://bugs.webkit.org/attachment.cgi?id=310948&action=review




--- Comment #10 from Nikita Vasilyev <nvasilyev at apple.com> ---
Created attachment 310948

  --> https://bugs.webkit.org/attachment.cgi?id=310948&action=review

Patch

(In reply to Nikita Vasilyev from comment #9)
> Now that I'm thinking about it, there should be no need to re-insert
> treeElements, they should have the go-to & close buttons already.
> I'll try to implement that instead.

This isn't necessarily a good idea because both Network and Resources sidebar
use the same TreeElement classes,
but tree elements in Network sidebar have the go-to arrows.

I think in the future we should re-consider the go-to arrow and close button UI
in Network tab. I've seen at least 3 people
confused not knowing how to close a content view in the Network tab.