[webkit-reviews] review granted: [Bug 138810] Web Inspector: New CSS Rules should go into a new Stylesheet Resource that can be viewed/edited/saved : [Attachment 310704] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 138810: Web Inspector: New CSS Rules should go into a new Stylesheet
Resource that can be viewed/edited/saved
https://bugs.webkit.org/show_bug.cgi?id=138810

Attachment 310704: Patch

https://bugs.webkit.org/attachment.cgi?id=310704&action=review




--- Comment #10 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 310704
  --> https://bugs.webkit.org/attachment.cgi?id=310704
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310704&action=review

r=me

I think there is still some hairiness around CSSStyleSheet being used like a
Resource but not being a Resource. I wish that would be cleaned up but I think
the general approach in this patch is sound.

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js:257
> +		       options.nameStyle =
WebInspector.SourceCodeLocation.NameStyle.None;

This is exactly why I don't like using `const` for things that aren't const
(namely: `options` here).