[webkit-reviews] review granted: [Bug 172455] FTL stack overflow handling should not assume that B3 never selects callee-saves in the prologue : [Attachment 310890] the patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 172455: FTL stack overflow handling should not assume that B3 never selects
callee-saves in the prologue
https://bugs.webkit.org/show_bug.cgi?id=172455

Attachment 310890: the patch

https://bugs.webkit.org/attachment.cgi?id=310890&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 310890
  --> https://bugs.webkit.org/attachment.cgi?id=310890
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310890&action=review

r=me with comment.

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:233
> +		       // OOPS! Need bug URL.

Please add bug url before landing.

> Source/JavaScriptCore/heap/Subspace.cpp:220
> +ALWAYS_INLINE void Subspace::didAllocate(void* ptr)
> +{
> +    UNUSED_PARAM(ptr);
> +    
> +    // This is useful for logging allocations, or doing other kinds of
debugging hacks. Just make
> +    // sure you JSC_forceGCSlowPaths=true.
> +}
> +

This set of changes (while useful) seems totally unrelated to this patch.  Did
you intend to include it?