[webkit-reviews] review denied: [Bug 172445] [WTF] Compilation fails with system malloc : [Attachment 310862] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 22 07:20:43 PDT 2017
Michael Catanzaro <mcatanzaro at igalia.com> has denied Tomas Popela
<tpopela at redhat.com>'s request for review:
Bug 172445: [WTF] Compilation fails with system malloc
https://bugs.webkit.org/show_bug.cgi?id=172445
Attachment 310862: Patch
https://bugs.webkit.org/attachment.cgi?id=310862&action=review
--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 310862
--> https://bugs.webkit.org/attachment.cgi?id=310862
Patch
Hm, good catch, thanks, but I think this should ensure the build fails if
USE_SYSTEM_MALLOC is OFF and OS is not UNIX. We should not allow other
platforms to remain broken at runtime without any compiler error.
More information about the webkit-reviews
mailing list