[webkit-reviews] review granted: [Bug 172352] NavigatorEME: null RefPtr<> dereference due to different calling conventions : [Attachment 310816] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 172352: NavigatorEME: null RefPtr<> dereference due to different calling
conventions
https://bugs.webkit.org/show_bug.cgi?id=172352

Attachment 310816: Patch

https://bugs.webkit.org/attachment.cgi?id=310816&action=review




--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 310816
  --> https://bugs.webkit.org/attachment.cgi?id=310816
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310816&action=review

> Source/WebCore/Modules/encryptedmedia/NavigatorEME.cpp:92
> +		   // Obtain reference to the key system string before the
`implementation` RefPtr<> is cleared out.
> +		   const String& keySystem = implementation->keySystem();

I understand now, we are releasing the RefPtr<>, but not implementation that is
transferred to the MediaKeySystemAccess, that's why we don't need to copy.
Right?