[webkit-reviews] review granted: [Bug 172433] Do no enter Subversion-specific logic when parsing Git-based Trac data. : [Attachment 310823] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jason Marcell
<jmarcell at apple.com>'s request for review:
Bug 172433: Do no enter Subversion-specific logic when parsing Git-based Trac
data.
https://bugs.webkit.org/show_bug.cgi?id=172433

Attachment 310823: Patch

https://bugs.webkit.org/attachment.cgi?id=310823&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 310823
  --> https://bugs.webkit.org/attachment.cgi?id=310823
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310823&action=review

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/T
rac.js:182
> +	   // Note: we have an overidden timeline.rss that adds git branches to
the Trac timeline RSS output (rdar://problem/23853623)

I suggest removing "Note:", as every comment is a note. Please also add a
period in the end to make it a proper sentence.