[webkit-reviews] review granted: [Bug 172225] [JSC] Make get_by_val & string "499" to number 499 : [Attachment 310757] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 172225: [JSC] Make get_by_val & string "499" to number 499
https://bugs.webkit.org/show_bug.cgi?id=172225

Attachment 310757: Patch

https://bugs.webkit.org/attachment.cgi?id=310757&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 310757
  --> https://bugs.webkit.org/attachment.cgi?id=310757
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310757&action=review

r=me

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:585
> +	       if (leftHandSideNeedsCopy(rightHasAssignments, rightIsPure)) {
> +		   RefPtr<RegisterID> dst = newTemporary();
> +		   emitNodeForProperty(dst.get(), n);
> +		   return dst;
> +	       }

Do you have a test for this?