[webkit-reviews] review granted: [Bug 171219] [GCrypt] RSAES-PKCS1-v1_5 support : [Attachment 308231] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 171219: [GCrypt] RSAES-PKCS1-v1_5 support
https://bugs.webkit.org/show_bug.cgi?id=171219

Attachment 308231: Patch

https://bugs.webkit.org/attachment.cgi?id=308231&action=review




--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 308231
  --> https://bugs.webkit.org/attachment.cgi?id=308231
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308231&action=review

I'm surprised that WebKit supports so many crypto algorithms that are not part
of the WebCryto standard. I know this is permitted, it's just unusual. Anyway,
thanks for bringing us up to feature parity with the Mac port.

As with all these WebCrypto patches, you should try to get a review from Jiewen
as well.

> Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:88
> +    // Return MPI data of the embedded a integer.

This comment is missing something!