[webkit-reviews] review granted: [Bug 172410] Value for iterator property is wrong for maplike interfaces : [Attachment 310772] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 172410: Value for iterator property is wrong for maplike interfaces
https://bugs.webkit.org/show_bug.cgi?id=172410

Attachment 310772: Patch

https://bugs.webkit.org/attachment.cgi?id=310772&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 310772
  --> https://bugs.webkit.org/attachment.cgi?id=310772
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310772&action=review

> Source/WebCore/Modules/mediastream/RTCStatsReport.idl:27
> +// FIXME: This should not be marked as [NoInterfaceObject].
>  [

Why not just do it now?

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3469
>	   if (InterfaceNeedsIterator($interface)) {
>	       AddToImplIncludes("<builtins/BuiltinNames.h>");
> -	       if (IsKeyValueIterableInterface($interface)) {
> +	       if (IsKeyValueIterableInterface($interface) or
$interface->mapLike) {

While you are in the neighborhood (not really, but whatever), consider removing
the comment:

    # FIXME: This should return 1 for maplike once we support them.
    return 1 if $interface->mapLike;

in InterfaceNeedsIterator()