[webkit-reviews] review denied: [Bug 172368] Fix `make distcheck` by including Tools/TestRunnerShared : [Attachment 310674] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Emanuele Aina
<emanuele.aina at collabora.com>'s request for review:
Bug 172368: Fix `make distcheck` by including Tools/TestRunnerShared
https://bugs.webkit.org/show_bug.cgi?id=172368

Attachment 310674: Patch

https://bugs.webkit.org/attachment.cgi?id=310674&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 310674
  --> https://bugs.webkit.org/attachment.cgi?id=310674
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310674&action=review

> Tools/gtk/make-dist.py:247
> -	   command = ['cmake', '-DPORT=%s' % port, '-DCMAKE_INSTALL_PREFIX=%s'
% install_dir, '-DCMAKE_BUILD_TYPE=Release', dist_dir]
> +	   command = ['cmake', '-DPORT=%s' % port, '-DCMAKE_INSTALL_PREFIX=%s'
% install_dir, '-DCMAKE_BUILD_TYPE=Release', '-DDEVELOPER_MODE=ON', dist_dir]

The point of make distcheck is precisely to make a production build, ensuring
it builds without the developer mode.

> Tools/gtk/manifest.txt.in:88
> +directory Tools/TestRunnerShared

I don't know why we are including WTR in the tarball, because I don't think
it's possible to run layout tests from a tarball anyway, since we are not
including all the webkitpy and tools required. I think the right fix for this
is to remove ImageDiff, WTR and DRT from the tarball. Only unit tests should be
included, I think.