[webkit-reviews] review granted: [Bug 172218] URLSearchParams / Headers objects @@iterator is not as per Web IDL spec : [Attachment 310701] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 172218: URLSearchParams / Headers objects @@iterator is not as per Web IDL
spec
https://bugs.webkit.org/show_bug.cgi?id=172218

Attachment 310701: Patch

https://bugs.webkit.org/attachment.cgi?id=310701&action=review




--- Comment #26 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 310701
  --> https://bugs.webkit.org/attachment.cgi?id=310701
Patch

Looks better indeed!
Might want to do some additional clean-up, see below.
Maybe we do not need to add Symbol.Iterator at all in IDLParser.pm and handle
it directly in CodeGeneratorJS.pm

View in context: https://bugs.webkit.org/attachment.cgi?id=310701&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:5439
> +	       $iterationKind = "Value" if $propertyName eq "entries" and not
$interface->iterable->isKeyValue;

We should not need to do anything with Symbol.Iterator here since we are
reusing entries or values for that.
We are generating code for nothing probably. Can we remove that case?
Probably also for these function declarations as well.

> Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp:300
>  

Yep, jsTestNodePrototypeFunctionSymbolIterator is probably not needed.