[webkit-reviews] review granted: [Bug 167708] [Cocoa] An exported Objective C class’s prototype and constructor don't persist across JSContext deallocation : [Attachment 310677] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 167708: [Cocoa] An exported Objective C class’s prototype and constructor
don't persist across JSContext deallocation
https://bugs.webkit.org/show_bug.cgi?id=167708

Attachment 310677: Patch

https://bugs.webkit.org/attachment.cgi?id=310677&action=review




--- Comment #8 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 310677
  --> https://bugs.webkit.org/attachment.cgi?id=310677
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310677&action=review

Mark is right about JSC_OBJC_API_ENABLED -- that's the GTK build failure.

> Source/JavaScriptCore/ChangeLog:11
> +	   Also, this patch fixes a "bug" where we would not just used the
object constructor/prototype for NSObject.

NSObject doesn't export anything to JavaScript. Is this change observable? If
so, we should add a test for it.