[webkit-reviews] review granted: [Bug 172374] webkitpy: Use simctl boot to run multiple simulators at once : [Attachment 310684] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 172374: webkitpy: Use simctl boot to run multiple simulators at once
https://bugs.webkit.org/show_bug.cgi?id=172374

Attachment 310684: Patch

https://bugs.webkit.org/attachment.cgi?id=310684&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 310684
  --> https://bugs.webkit.org/attachment.cgi?id=310684
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310684&action=review

> Tools/Scripts/webkitpy/port/ios_simulator.py:173
> +    def has_old_xcode(self):

I'd call this use_multiple_simulator_apps.

> Tools/Scripts/webkitpy/port/ios_simulator.py:235
> +	   _log.info('Simulators have booted.')

Maybe this would be more clear: "All simulators have booted."