[webkit-reviews] review granted: [Bug 172362] Make sure implementation of InitializeWebKit2() always run on the main thread : [Attachment 310670] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 172362: Make sure implementation of InitializeWebKit2() always run on the
main thread
https://bugs.webkit.org/show_bug.cgi?id=172362

Attachment 310670: Patch

https://bugs.webkit.org/attachment.cgi?id=310670&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 310670
  --> https://bugs.webkit.org/attachment.cgi?id=310670
Patch

I think this is a fine work-around for the threading problems we've discovered
in Safari.

In the long run, I think we need to remove this design. Instead of wallpapering
over threading problems, since this is a main-thread-only API, we should ASSERT
that it's only invoked on the main thread, and fix the cases where that's not
true.