[webkit-reviews] review granted: [Bug 172349] ScrollingStateScrollingNode::ChangedProperty::NumScrollingStateNodeBits is wrongly set : [Attachment 310655] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 172349:
ScrollingStateScrollingNode::ChangedProperty::NumScrollingStateNodeBits is
wrongly set
https://bugs.webkit.org/show_bug.cgi?id=172349

Attachment 310655: Patch

https://bugs.webkit.org/attachment.cgi?id=310655&action=review




--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 310655
  --> https://bugs.webkit.org/attachment.cgi?id=310655
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310655&action=review

Nice find!

> Source/WebCore/page/scrolling/ScrollingStateNode.h:208
> +    typedef uint64_t ChangedProperties;

There's no actual need to do this change now, right? We never have more than 32
bits.