[webkit-reviews] review granted: [Bug 172361] matchMedia('print').addListener() fires in WK1 but never in WK2 when printing (breaks printing Google maps, QuickLooks) : [Attachment 310665] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 19 10:01:58 PDT 2017


Sam Weinig <sam at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 172361: matchMedia('print').addListener() fires in WK1 but never in WK2
when printing (breaks printing Google maps, QuickLooks)
https://bugs.webkit.org/show_bug.cgi?id=172361

Attachment 310665: patch

https://bugs.webkit.org/attachment.cgi?id=310665&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 310665
  --> https://bugs.webkit.org/attachment.cgi?id=310665
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310665&action=review

> Source/WebCore/ChangeLog:14
> +	   (WebCore::FrameView::layout):
> +
> +	       Evaluate matchMedia queries unconditionally. No idea why it
wasn't like that.

Out of curiosity, what made this work in WK1 but not WK2?


More information about the webkit-reviews mailing list