[webkit-reviews] review denied: [Bug 172332] cp949 is not a known text encoding name : [Attachment 310592] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 19 09:52:18 PDT 2017


Alexey Proskuryakov <ap at webkit.org> has denied	review:
Bug 172332: cp949 is not a known text encoding name
https://bugs.webkit.org/show_bug.cgi?id=172332

Attachment 310592: Patch

https://bugs.webkit.org/attachment.cgi?id=310592&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 310592
  --> https://bugs.webkit.org/attachment.cgi?id=310592
Patch

I don't think that we should do this.

1. This encoding name is not in the Web encoding spec
<https://encoding.spec.whatwg.org>, and other browsers don't support it.

2. The way this patch implements cp949 doesn't match any non-Web encoding
standard either. In ICU, this name maps to ibm-949 encoding, which is entirely
different from windows-949:
<http://demo.icu-project.org/icu-bin/convexp?s=IANA&s=MIME&s=ALL>. I think that
it's a bug somewhere in the client that it passes cp949 when it actually means
windows-949 or some other EUC-KR variant.


More information about the webkit-reviews mailing list