[webkit-reviews] review granted: [Bug 172345] REGRESSION(r216977): [GTK] Ephemeral sessions broken after r216977 : [Attachment 310625] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 172345: REGRESSION(r216977): [GTK] Ephemeral sessions broken after r216977
https://bugs.webkit.org/show_bug.cgi?id=172345

Attachment 310625: Patch

https://bugs.webkit.org/attachment.cgi?id=310625&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 310625
  --> https://bugs.webkit.org/attachment.cgi?id=310625
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310625&action=review

Glad the API tests caught this.

Technically you need an owner to approve the cross-platform assertion, but
since it's one line I assume you can get approval on IRC on something.

> Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:1302
> +    // FIXME: Implement cookies.

What needs to happen here?