[webkit-reviews] review canceled: [Bug 172352] NavigatorEME: null RefPtr<> dereference due to different calling conventions : [Attachment 310643] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has canceled Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 172352: NavigatorEME: null RefPtr<> dereference due to different calling
conventions
https://bugs.webkit.org/show_bug.cgi?id=172352

Attachment 310643: Patch

https://bugs.webkit.org/attachment.cgi?id=310643&action=review




--- Comment #5 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 310643
  --> https://bugs.webkit.org/attachment.cgi?id=310643
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310643&action=review

>> Source/WebCore/Modules/encryptedmedia/NavigatorEME.cpp:92
>> +		    const Sting& keySystem = implementation->keySystem();
> 
> How can this build? Sting -> String Are we really copying it when using const
String&

Initially it was copying it. Changed it to a reference before uploading, forgot
to update the comment, and didn't recompile after the change.