[webkit-reviews] review requested: [Bug 172267] [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib : [Attachment 310639] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 19 02:47:09 PDT 2017


Fujii Hironori <Hironori.Fujii at sony.com> has asked  for review:
Bug 172267: [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint()
already defined in WebKit.lib
https://bugs.webkit.org/show_bug.cgi?id=172267

Attachment 310639: Patch

https://bugs.webkit.org/attachment.cgi?id=310639&action=review




--- Comment #11 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Created attachment 310639

  --> https://bugs.webkit.org/attachment.cgi?id=310639&action=review

Patch

This is a layer violation and TestWebCore is just a unit test. I'd like to
suggest to add a stub in TestWebCoreLib. How do you think this?


More information about the webkit-reviews mailing list