[webkit-reviews] review granted: [Bug 172341] Speedometer 2.0: jQuery and Inferno tests don't delete all ToDo items : [Attachment 310615] Added missing changes to InteractiveRunner.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 19 02:02:24 PDT 2017


Antti Koivisto <koivisto at iki.fi> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 172341: Speedometer 2.0: jQuery and Inferno tests don't delete all ToDo
items
https://bugs.webkit.org/show_bug.cgi?id=172341

Attachment 310615: Added missing changes to InteractiveRunner.html

https://bugs.webkit.org/attachment.cgi?id=310615&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 310615
  --> https://bugs.webkit.org/attachment.cgi?id=310615
Added missing changes to InteractiveRunner.html

View in context: https://bugs.webkit.org/attachment.cgi?id=310615&action=review

> PerformanceTests/Speedometer/resources/tests.js:343
> -	       var checkboxes = contentDocument.querySelectorAll('.toggle');
> +	       var checkboxes =
contentDocument.getElementsByClassName('toggle');

Why the switch? You mostly use querySelector.


More information about the webkit-reviews mailing list