[webkit-reviews] review granted: [Bug 172310] [WebIDL] Remove the need for the generator to know about native type mapping : [Attachment 310572] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 172310: [WebIDL] Remove the need for the generator to know about native
type mapping
https://bugs.webkit.org/show_bug.cgi?id=172310

Attachment 310572: Patch

https://bugs.webkit.org/attachment.cgi?id=310572&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 310572
  --> https://bugs.webkit.org/attachment.cgi?id=310572
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310572&action=review

> Source/WebCore/Modules/geolocation/Geolocation.cpp:511
>	   RefPtr<PositionError> error =
PositionError::create(PositionError::PERMISSION_DENIED, 
ASCIILiteral(permissionDeniedErrorMessage));

auto/Ref

> Source/WebCore/Modules/geolocation/Geolocation.cpp:525
> +    RefPtr<Geoposition> position = lastPosition();
> +    if (position)

Would be nice to define inside the if. Does this need to go into a RefPtr
rather than a raw pointer?

> Source/WebCore/Modules/geolocation/Geolocation.cpp:690
> +    RefPtr<Geoposition> position = lastPosition();
> +    ASSERT(position);

Does this need to go into a RefPtr rather than a raw pointer?

> Source/WebCore/Modules/geolocation/Geolocation.cpp:701
>      RefPtr<PositionError> positionError = createPositionError(error);

auto/Ref

> Source/WebCore/Modules/webaudio/AudioBufferCallback.idl:27
> +// DecodeErrorCallback, which takes DOMException. Currently, we pass and
AudioBuffer

"and" -> "an"

> Source/WebKit/mac/DOM/DOM.mm:861
> -    return core(self)->acceptNode(core(node));
> +    return core(self)->acceptNode(*core(node));

Would be more elegant to throw an exception if someone passes nil rather than
crashing.