[webkit-reviews] review granted: [Bug 164849] Proxy's [[Get]] passes incorrect receiver : [Attachment 310580] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 164849: Proxy's [[Get]] passes incorrect receiver
https://bugs.webkit.org/show_bug.cgi?id=164849

Attachment 310580: patch

https://bugs.webkit.org/attachment.cgi?id=310580&action=review




--- Comment #5 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 310580
  --> https://bugs.webkit.org/attachment.cgi?id=310580
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310580&action=review

r=me

> JSTests/stress/proxy-get-set-correct-receiver.js:36
> +	       assert(this === proxy)

OK, receiver is proxy.

> JSTests/stress/proxy-get-set-correct-receiver.js:50
> +	       assert(this === proxy)

OK, receiver is neither p1 nor target.

> Source/JavaScriptCore/runtime/ProxyObject.cpp:135
> +	   return jsUndefined();

OK, previously, we ignored receiver.