[webkit-reviews] review granted: [Bug 172309] Redundant ellipsis box triggers ASSERT_WITH_SECURITY_IMPLICATION in InlineBox::parent(). : [Attachment 310571] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 172309: Redundant ellipsis box triggers ASSERT_WITH_SECURITY_IMPLICATION in
InlineBox::parent().
https://bugs.webkit.org/show_bug.cgi?id=172309

Attachment 310571: Patch

https://bugs.webkit.org/attachment.cgi?id=310571&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 310571
  --> https://bugs.webkit.org/attachment.cgi?id=310571
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310571&action=review

> Source/WebCore/rendering/InlineBox.h:416
> +    bool m_inChildList { true };

Maybe call this m_isEverInChildList, or even m_isEllipsisBox.