[webkit-reviews] review denied: [Bug 171997] navigator.webdriver should return false if the page is not controlled by automation : [Attachment 310570] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Sergey Shekyan <shekyan at gmail.com>'s
request for review:
Bug 171997: navigator.webdriver should return false if the page is not
controlled by automation
https://bugs.webkit.org/show_bug.cgi?id=171997

Attachment 310570: Patch

https://bugs.webkit.org/attachment.cgi?id=310570&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 310570
  --> https://bugs.webkit.org/attachment.cgi?id=310570
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310570&action=review

This needs a layout test to check that:
1. The property is false instead of being undefined now
2. The property is not configurable (Assuming this part of your change is
right)
3. The property is enumerable (as I think it should be as per the spec).

> Source/WebCore/ChangeLog:8
> +

Please add a link to the spec in your changelog.

> Source/WebCore/Modules/webdriver/NavigatorWebDriver.idl:27
> +    [Unforgeable, NotEnumerable, Custom] readonly attribute boolean
webdriver;

We no longer need custom code at all. [Custom] should be dropped and the
implementation should be updated accordingly.

Could you also point to the spec that says it should be Unforgeable? I do know
that [NotEnumerable] is not as per spec and should be dropped but last time I
checked, there was no [Unforgeable] in the spec.