[webkit-reviews] review granted: [Bug 172304] Web Inspector: Use initialLayout for Settings tab : [Attachment 310554] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 172304: Web Inspector: Use initialLayout for Settings tab
https://bugs.webkit.org/show_bug.cgi?id=172304

Attachment 310554: Patch

https://bugs.webkit.org/attachment.cgi?id=310554&action=review




--- Comment #10 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 310554
  --> https://bugs.webkit.org/attachment.cgi?id=310554
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310554&action=review

r=me, with a comment

> Source/WebInspectorUI/ChangeLog:16
> +	   Move the code for doing this to initialLayout ensures it to happens
once, but only after the

Awkward wording, maybe: "Use initialLayout to ensure UI gets created exactly
once, after the tab is selected."

> Source/WebInspectorUI/UserInterface/Views/GeneralSettingsView.js:84
> +	  
WebInspector.settings.zoomFactor.addEventListener(WebInspector.Setting.Event.Ch
anged, () => { zoomEditor.value = WebInspector.getZoomFactor().maxDecimals(2);
});

Nice, it looks like the control wasn't updating at all before:

1. Open Settings (pre-patch)
2. Scroll / resize so Zoom level is visible
3. Hit Cmd-+/-
  => Still says 100%