[webkit-reviews] review granted: [Bug 163899] WebAssembly API: test with neutered inputs : [Attachment 310516] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 18 10:38:56 PDT 2017


Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 163899: WebAssembly API: test with neutered inputs
https://bugs.webkit.org/show_bug.cgi?id=163899

Attachment 310516: Patch

https://bugs.webkit.org/attachment.cgi?id=310516&action=review




--- Comment #25 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 310516
  --> https://bugs.webkit.org/attachment.cgi?id=310516
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310516&action=review

r=me

> Source/WebCore/ChangeLog:9
> +	   Make it not possible to transfer an ArrayBuffer that is backing a
> +	   wasm memory.

backing => backed by

> Source/JavaScriptCore/runtime/ArrayBuffer.h:163
> +    bool m_isWasmMemory : 1;

Don't you need to always initialize this to false? I don't see where you do
that.


More information about the webkit-reviews mailing list