[webkit-reviews] review granted: [Bug 172038] REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent window CSP when object-src 'none' is set : [Attachment 310481] Patch and layout tests

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 172038: REGRESSION (r209608): Cross-origin plugin document opened in child
window blocked by parent window CSP when object-src 'none' is set
https://bugs.webkit.org/show_bug.cgi?id=172038

Attachment 310481: Patch and layout tests

https://bugs.webkit.org/attachment.cgi?id=310481&action=review




--- Comment #25 from Andy Estes <aestes at apple.com> ---
Comment on attachment 310481
  --> https://bugs.webkit.org/attachment.cgi?id=310481
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=310481&action=review

> Source/WebCore/dom/Document.cpp:5216
> +    Frame* parentFrame = m_frame->tree().parent();
> +    if (parentFrame)

You don't need the parentFrame local variable since you don't use if after the
null check.