[webkit-reviews] review granted: [Bug 172129] WebAssembly: exports is a getter : [Attachment 310490] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 18 09:25:03 PDT 2017


Saam Barati <sbarati at apple.com> has granted JF Bastien <jfbastien at apple.com>'s
request for review:
Bug 172129: WebAssembly: exports is a getter
https://bugs.webkit.org/show_bug.cgi?id=172129

Attachment 310490: patch

https://bugs.webkit.org/attachment.cgi?id=310490&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 310490
  --> https://bugs.webkit.org/attachment.cgi?id=310490
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310490&action=review

r=me

> JSTests/wasm/js-api/test_basic_api.js:74
> +	   assert.throws(() => WebAssembly.Instance.prototype.exports =
undefined, TypeError, `Attempted to assign to readonly property.`);

Please add a test where you do getOwnProperty and assert the property
descriptor is what you expect. Also, please add tests where you throw because
the |this| is not an instance.

> Source/JavaScriptCore/wasm/js/WebAssemblyInstancePrototype.cpp:48
> + exports webAssemblyInstanceProtoFuncExports DontEnum|Accessor 0

Is it a configurable property?


More information about the webkit-reviews mailing list