[webkit-reviews] review canceled: [Bug 172259] Remote Inspector: Be stricter about checking message types : [Attachment 310482] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 17 21:03:06 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has canceled Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 172259: Remote Inspector: Be stricter about checking message types
https://bugs.webkit.org/show_bug.cgi?id=172259

Attachment 310482: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=310482&action=review




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 310482
  --> https://bugs.webkit.org/attachment.cgi?id=310482
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=310482&action=review

> Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:-498
> -    unsigned targetIdentifier = [[userInfo
objectForKey:WIRTargetIdentifierKey] unsignedIntegerValue];

On second thought, these should all be `unsignedIntValue` which returns a
`unsigned` type not `NSUInteger`.


More information about the webkit-reviews mailing list