[webkit-reviews] review granted: [Bug 172188] We don't do context switches for Wasm->Wasm call indirect : [Attachment 310340] patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 172188: We don't do context switches for Wasm->Wasm call indirect
https://bugs.webkit.org/show_bug.cgi?id=172188

Attachment 310340: patch

https://bugs.webkit.org/attachment.cgi?id=310340&action=review




--- Comment #14 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 310340
  --> https://bugs.webkit.org/attachment.cgi?id=310340
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310340&action=review

r=me.

>> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:1155
>> +	    BasicBlock* doContextSwitch = m_proc.addBlock();
> 
> These should probably be switched for better block ordering.

I don't think this matters. Doesn't B3 pick the ordering it wants later anyway?

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:1164
> +	   PatchpointValue* patchpoint =
doContextSwitch->appendNew<PatchpointValue>(m_proc, B3::Void, origin());

I think you need to say this writes pinned.