[webkit-reviews] review denied: [Bug 172230] [Win][CMake] Move MSVC compiler options to a common location : [Attachment 310439] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 17 14:02:54 PDT 2017


Alex Christensen <achristensen at apple.com> has denied Don Olmstead
<don.olmstead at am.sony.com>'s request for review:
Bug 172230: [Win][CMake] Move MSVC compiler options to a common location
https://bugs.webkit.org/show_bug.cgi?id=172230

Attachment 310439: Patch

https://bugs.webkit.org/attachment.cgi?id=310439&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 310439
  --> https://bugs.webkit.org/attachment.cgi?id=310439
Patch

There is no way to use MSVC on a non-Windows platform.	I see no reason to move
this from a Windows-specific file to a file that's used on Linux and Mac.


More information about the webkit-reviews mailing list