[webkit-reviews] review granted: [Bug 172098] [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass : [Attachment 310354] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 172098: [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
https://bugs.webkit.org/show_bug.cgi?id=172098

Attachment 310354: Patch

https://bugs.webkit.org/attachment.cgi?id=310354&action=review




--- Comment #16 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 310354
  --> https://bugs.webkit.org/attachment.cgi?id=310354
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310354&action=review

r=me

> Source/JavaScriptCore/ChangeLog:18
> +	   One problem is that it enlarges the size of ClassInfo.
> +	   But this is the best place to put this function pointer.

I don't think this will matter much in practice, since ClassInfo size is
bounded per process.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7931
> +    RefPtr<DOMJIT::Patchpoint> patchpoint =
classInfo->checkSubClassPatchpoint();

Style nit: It seems weird we're still calling this a DOMJIT::Patchpoint even
though the function is called checkSubClassPatchpoint.

> Source/JavaScriptCore/runtime/ClassInfo.cpp:33
> +void ClassInfo::dump(PrintStream& out) const

nice!

> Source/JavaScriptCore/runtime/ClassInfo.h:214
> +    JS_EXPORT_PRIVATE void dump(PrintStream&) const;

Is this the WTF dataLog compatible way of printing?