[webkit-reviews] review granted: [Bug 172214] More WebKit2 header cleanup : [Attachment 310364] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 172214: More WebKit2 header cleanup
https://bugs.webkit.org/show_bug.cgi?id=172214

Attachment 310364: Patch

https://bugs.webkit.org/attachment.cgi?id=310364&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 310364
  --> https://bugs.webkit.org/attachment.cgi?id=310364
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310364&action=review

>> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1691
>> +	if (m_findController->isShowingOverlay()) {
> 
> I wonder if people would prefer to use the (inlinable) findController()
method instead so that we can still use dot syntax and don't have to worry
about whether it can be null (too bad UniqueRef can't make dot work :( )

Yes.