[webkit-reviews] review requested: [Bug 172186] [iOS] The Garbage Collector shouldn't rely on the bmalloc scavenger for up to date memory footprint info : [Attachment 310416] Updated Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 17 11:36:25 PDT 2017


Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 172186: [iOS] The Garbage Collector shouldn't rely on the bmalloc scavenger
for up to date memory footprint info
https://bugs.webkit.org/show_bug.cgi?id=172186

Attachment 310416: Updated Patch

https://bugs.webkit.org/attachment.cgi?id=310416&action=review




--- Comment #9 from Michael Saboff <msaboff at apple.com> ---
Created attachment 310416

  --> https://bugs.webkit.org/attachment.cgi?id=310416&action=review

Updated Patch

This patch implements what ggaren is asking for, specifically that the GC
doesn't rely on cached values from the scavenger.  The GC implements its own
cache of overCriticalMemoryThreshold and gets that value fresh at the end of
collection for the next cycle.	The cache is still updated 1 out of every 100
calls to overCriticalMemoryThreshold().


More information about the webkit-reviews mailing list