[webkit-reviews] review granted: [Bug 172213] Speedometer: check-in missing React TodoMVC dependency : [Attachment 310361] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 17 04:32:48 PDT 2017
David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Addy Osmani
<addyo at chromium.org>'s request for review:
Bug 172213: Speedometer: check-in missing React TodoMVC dependency
https://bugs.webkit.org/show_bug.cgi?id=172213
Attachment 310361: Patch
https://bugs.webkit.org/attachment.cgi?id=310361&action=review
--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 310361
--> https://bugs.webkit.org/attachment.cgi?id=310361
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=310361&action=review
r=me, but consider using director.min.js.
>
PerformanceTests/Speedometer/resources/todomvc/architecture-examples/react/inde
x.html:17
> + <script src="node_modules/director/director.js"></script>
Don't you want to use director.min.js here to match other resources?
More information about the webkit-reviews
mailing list