[webkit-reviews] review granted: [Bug 172006] [macOS] REGRESSION: Drag images for links with right-to-left titles are incorrect : [Attachment 310322] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 172006: [macOS] REGRESSION: Drag images for links with right-to-left titles
are incorrect
https://bugs.webkit.org/show_bug.cgi?id=172006

Attachment 310322: Patch

https://bugs.webkit.org/attachment.cgi?id=310322&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 310322
  --> https://bugs.webkit.org/attachment.cgi?id=310322
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310322&action=review

Where are the tests?

> Source/WebCore/platform/mac/DragImageMac.mm:219
> +	   CTParagraphStyleSetting paragraphStyleSettings[1];

Should paragraphStyleSettings be captured?