[webkit-reviews] review granted: [Bug 172174] Tighten TextIterator::handleTextNode run-renderer mapping logic. : [Attachment 310271] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 172174: Tighten TextIterator::handleTextNode run-renderer mapping logic.
https://bugs.webkit.org/show_bug.cgi?id=172174

Attachment 310271: Patch

https://bugs.webkit.org/attachment.cgi?id=310271&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 310271
  --> https://bugs.webkit.org/attachment.cgi?id=310271
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310271&action=review

> Source/WebCore/editing/TextIterator.cpp:656
> +	   // If the position we are looking for is to the left of the
renderer's first run, it means that
> +	   // the runs and the renderers are out of sync (e.g. we skipped a
renderer in between).
> +	   // Better bail out at this point.

Should we have an assert for this?