[webkit-reviews] review denied: [Bug 172083] ENABLE(WEBASSEMBLY) shouldn't be defined using defined() : [Attachment 310190] Patch v2 (to double-check El Capitan EWS)

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has denied David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 172083: ENABLE(WEBASSEMBLY) shouldn't be defined using defined()
https://bugs.webkit.org/show_bug.cgi?id=172083

Attachment 310190: Patch v2 (to double-check El Capitan EWS)

https://bugs.webkit.org/attachment.cgi?id=310190&action=review




--- Comment #29 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 310190
  --> https://bugs.webkit.org/attachment.cgi?id=310190
Patch v2 (to double-check El Capitan EWS)

Okay, I know why this fails.  It's because:

1. ENABLE_WEBASSEMBLY is defined in FeatureDefines.h.
2. FeatureDefines.h is included in Platform.h, but *before* ENABLE_B3_JIT is
defined.

Thus ENABLE_WEBASSEMBLY gets set to 0 with this patch because ENABLE_B3_JIT is
not defined yet.