[webkit-reviews] review granted: [Bug 172162] [WPE] GLContextEGL::createWPEContext() should fall back to pbuffer-based contexts when offscreen target provides no native window : [Attachment 310231] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 172162: [WPE] GLContextEGL::createWPEContext() should fall back to
pbuffer-based contexts when offscreen target provides no native window
https://bugs.webkit.org/show_bug.cgi?id=172162

Attachment 310231: Patch

https://bugs.webkit.org/attachment.cgi?id=310231&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 310231
  --> https://bugs.webkit.org/attachment.cgi?id=310231
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310231&action=review

> Source/WebCore/platform/graphics/egl/GLContextEGLWPE.cpp:36
> +    if (!context)
> +	   context = createPbufferContext(platformDisplay, sharingContext);

Why not falling back to a surfaceless context if available?