[webkit-reviews] review granted: [Bug 168836] WebAssembly: validate load / store alignment : [Attachment 309878] patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted JF Bastien
<jfbastien at apple.com>'s request for review:
Bug 168836: WebAssembly: validate load / store alignment
https://bugs.webkit.org/show_bug.cgi?id=168836

Attachment 309878: patch

https://bugs.webkit.org/attachment.cgi?id=309878&action=review




--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 309878
  --> https://bugs.webkit.org/attachment.cgi?id=309878
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309878&action=review

r=me. with nit... maybe?

> Source/JavaScriptCore/wasm/generateWasm.py:105
> +    return str(int(math.log(memoryBits, 2)))

nit: math.log doesn't return an int? O.o