[webkit-reviews] review denied: [Bug 163899] WebAssembly API: test with neutered inputs : [Attachment 310230] Patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has denied  review:
Bug 163899: WebAssembly API: test with neutered inputs
https://bugs.webkit.org/show_bug.cgi?id=163899

Attachment 310230: Patch

https://bugs.webkit.org/attachment.cgi?id=310230&action=review




--- Comment #5 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 310230
  --> https://bugs.webkit.org/attachment.cgi?id=310230
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310230&action=review

Missing the FIXME in JSTests/wasm/js-api/test_basic_api.js

I'm not familiar with all the places where the transferability should be
checked, so it would be good to have another set of eyes look and make sure
this is correct.

> Source/JavaScriptCore/wasm/js/JSWebAssemblyMemory.cpp:71
> +    m_buffer->makeNonTransferable();

There's also code in WebAssemblyModuleConstructor.cpp which needs this.

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:3003
> +		   throwVMTypeError(&state, scope, ASCIILiteral("Cannot
transfer a WebAssembly.Memory"));

Weird that the property is "non-transferable" but the error message knows it's
a WebAssembly.Memory. I'd change one to match the other.

> LayoutTests/ChangeLog:7
> +

Can you explain that this dups Saam's dup of the de-modularized Builder?