[webkit-reviews] review granted: [Bug 163899] WebAssembly API: test with neutered inputs : [Attachment 310230] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 163899: WebAssembly API: test with neutered inputs
https://bugs.webkit.org/show_bug.cgi?id=163899

Attachment 310230: Patch

https://bugs.webkit.org/attachment.cgi?id=310230&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 310230
  --> https://bugs.webkit.org/attachment.cgi?id=310230
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310230&action=review

r=me with comment

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:3001
> +	       if (!arrayBuffer->isTransferable()) {

I wouldn’t do it quite like this, since this error message only makes sense
given the above isShared check. Maybe remove the above check and come up with a
more descriptive way of having different error messages for different
untransferable arrays? Alternatively, you could have a more generic message.
Perhaps you could even have a bit that says if it’s Wasm, and if so, have a
more descriptive message