[webkit-reviews] review granted: [Bug 172145] Captions and subtitles not showing up in picture-in-picture for MSE content. : [Attachment 310188] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 172145: Captions and subtitles not showing up in picture-in-picture for MSE
content.
https://bugs.webkit.org/show_bug.cgi?id=172145

Attachment 310188: Patch

https://bugs.webkit.org/attachment.cgi?id=310188&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 310188
  --> https://bugs.webkit.org/attachment.cgi?id=310188
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310188&action=review

> Source/WebCore/ChangeLog:11
> +	   This movest the TextTrackRepresentation platfrom layer into the
fullscreen container layer when going into

Nit: movest

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourc
eAVFObjC.mm:938
> +    FloatRect videoFullscreenFrame =
m_videoFullscreenLayerManager->videoFullscreenFrame();

Nit: auto

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourc
eAVFObjC.mm:939
> +    CGRect videoRect = [m_sampleBufferDisplayLayer bounds];

Ditto

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourc
eAVFObjC.mm:940
> +    CGRect textFrame = m_sampleBufferDisplayLayer ? videoRect :
CGRectMake(0, 0, videoFullscreenFrame.width(), videoFullscreenFrame.height());

Ditto