[webkit-reviews] review granted: [Bug 172140] Migrate Font constructor from bools to enums : [Attachment 310191] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 172140: Migrate Font constructor from bools to enums
https://bugs.webkit.org/show_bug.cgi?id=172140

Attachment 310191: Patch

https://bugs.webkit.org/attachment.cgi?id=310191&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 310191
  --> https://bugs.webkit.org/attachment.cgi?id=310191
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310191&action=review

> Source/WebCore/platform/graphics/Font.h:308
> +    unsigned m_origin : 1; // Whether or not we are custom font loaded via
@font-face
> +    unsigned m_isInterstitial : 1; // Whether or not this custom font is the
last resort placeholder for a loading font

These could totally be your enum if you wanted. But this is much better.