[webkit-reviews] review granted: [Bug 172114] Align WebKitCSSMatrix stringifier with spec for DOMMatrix : [Attachment 310156] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 172114: Align WebKitCSSMatrix stringifier with spec for DOMMatrix
https://bugs.webkit.org/show_bug.cgi?id=172114

Attachment 310156: Patch

https://bugs.webkit.org/attachment.cgi?id=310156&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 310156
  --> https://bugs.webkit.org/attachment.cgi?id=310156
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310156&action=review

> Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1702
> +	   && std::isfinite(m_matrix[3][3]);

What happened to m_matrix[3][0], m_matrix[3][1], m_matrix[3][2] ?

> LayoutTests/fast/css/matrix-stringifier-expected.txt:19
> +FAIL DOMMatrix stringifier: identity (2d) undefined is not a constructor
(evaluating 'new self[constr]()')
> +FAIL DOMMatrix stringifier: integer 2d undefined is not a constructor
(evaluating 'new self[constr]("matrix(1, 0, 0, 1, 0, 0)")')
> +FAIL DOMMatrix stringifier: integer 3d undefined is not a constructor
(evaluating 'new self[constr]("matrix3d(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0,
0, 0, 1)")')
> +FAIL DOMMatrix stringifier: floating point 2d undefined is not a constructor
(evaluating 'new self[constr]("matrix(0.1, 0.2, 0.3, 0.4, 0.5, 0.6)")')
> +FAIL DOMMatrix stringifier: floating point 3d undefined is not a constructor
(evaluating 'new self[constr]("matrix3d(0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8,
0.9, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7)")')
> +FAIL DOMMatrix stringifier: NaN undefined is not a constructor (evaluating
'new self[constr]()')
> +FAIL DOMMatrix stringifier: Infinity undefined is not a constructor
(evaluating 'new self[constr]()')
> +FAIL DOMMatrix stringifier: -Infinity undefined is not a constructor
(evaluating 'new self[constr]()')
> +FAIL ${constr}.toString should be enumerable undefined is not an object
(evaluating 'self[constr].prototype')
> +FAIL DOMMatrixReadOnly stringifier: identity (2d) undefined is not a
constructor (evaluating 'new self[constr]()')
> +FAIL DOMMatrixReadOnly stringifier: integer 2d undefined is not a
constructor (evaluating 'new self[constr]("matrix(1, 0, 0, 1, 0, 0)")')
> +FAIL DOMMatrixReadOnly stringifier: integer 3d undefined is not a
constructor (evaluating 'new self[constr]("matrix3d(1, 0, 0, 0, 0, 1, 0, 0, 0,
0, 1, 0, 0, 0, 0, 1)")')
> +FAIL DOMMatrixReadOnly stringifier: floating point 2d undefined is not a
constructor (evaluating 'new self[constr]("matrix(0.1, 0.2, 0.3, 0.4, 0.5,
0.6)")')
> +FAIL DOMMatrixReadOnly stringifier: floating point 3d undefined is not a
constructor (evaluating 'new self[constr]("matrix3d(0.1, 0.2, 0.3, 0.4, 0.5,
0.6, 0.7, 0.8, 0.9, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7)")')
> +FAIL DOMMatrixReadOnly stringifier: NaN undefined is not a constructor
(evaluating 'new self[constr]()')
> +FAIL DOMMatrixReadOnly stringifier: Infinity undefined is not a constructor
(evaluating 'new self[constr]()')
> +FAIL DOMMatrixReadOnly stringifier: -Infinity undefined is not a constructor
(evaluating 'new self[constr]()')
> +FAIL ${constr}.toString should be enumerable undefined is not an object
(evaluating 'self[constr].prototype')

I assume these fails are expected at this point?