[webkit-reviews] review granted: [Bug 170627] WebRTC outgoing muted video sources should send black frames : [Attachment 309743] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 170627: WebRTC outgoing muted video sources should send black frames
https://bugs.webkit.org/show_bug.cgi?id=170627

Attachment 309743: Patch

https://bugs.webkit.org/attachment.cgi?id=309743&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 309743
  --> https://bugs.webkit.org/attachment.cgi?id=309743
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309743&action=review

> Source/WebCore/ChangeLog:11
> +	   Instead of sending one black frame and then another one
asynchronously, we use the timer to send a black frame every second when
outgoing source is muted.

Nit: this line should be wrapped to a more reasonable length.

> LayoutTests/webrtc/video-mute.html:90
> +	return Promise.reject("This test requires internals API");

Nit: indentation